Tibor17 commented on a change in pull request #387:
URL: https://github.com/apache/maven-surefire/pull/387#discussion_r789267882
##########
File path:
surefire-booter/src/test/java/org/apache/maven/surefire/booter/SystemUtilsTest.java
##########
@@ -98,6 +98,15 @@ public void incorrectJdkPath()
assertThat( SystemUtils.isJava9AtLeast(
incorrect.getAbsolutePath() ) ).isFalse();
}
+ @Test
+ public void incorrectJdkPathShouldNotNPE()
Review comment:
@CMoH
We can accept this fix for the unit test but more important would be to back
track the callers in `AbstractSurefireMojo` and see if this NPE may happen and
may have some influence, and where if any.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]