michael-o commented on a change in pull request #131: URL: https://github.com/apache/maven-resolver/pull/131#discussion_r762562131
########## File path: maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/FileSystemFriendly.java ########## @@ -0,0 +1,30 @@ +package org.eclipse.aether.named.support; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * A marker interface that mark component "file system friendly". In case of lock factory, it would mean that + * passed in lock names MUST ADHERE to file path naming convention (and not use some special, non FS friendly + * characters in it). Essentially, component marked with this interface expects (or uses) that "name" is an absolute + * and valid file path. + */ +public interface FileSystemFriendly Review comment: Can you mark this as experimental. I'd like to solve this on a more generic level like * `boolean LockName#supportsFeature(String)` * `Collection<String> LockFactory#requiresFeatures()` * and an order/priority elment if more than one lock name implementation is available. Then the factory can select the best lock name impl and throw an expception if no one is found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
