[ https://issues.apache.org/jira/browse/MWAR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
wei cai updated MWAR-445: ------------------------- Description: Currently to build a war archive, maven-war-plugin need: * source paths (libraries, src/main/webapp...) -> exploded war -> build archive Many files need to be copied to exploded war directory before creating war archive. To speed up the maven-war-plugin, I would like to propose below solution: * source paths (libraries, src/main/webapp...) -> build archive Here when "-Dmaven.war.exploded.skip=true" is passed, the maven-war-plugin then build the archive directly based on all source paths, in this way, massive file copying can be avoided. maven.war.exploded.skip is by default set as false as there might be a few cases user want an exploded war, for example: * Using tomcat7-maven-plugin to start exploded webapp I created the PR: [https://github.com/apache/maven-war-plugin/pull/21] for initial discussion. Please help review and advise: * Does it make sense to skip the creation of exploded war? Any features will break because of this? * Regarding the ITs, shall I separate the tests into 2 scenarios? ** ITs for original behavior. ** ITs for building war archive without creating exploded war. was: Currently to build a war archive, maven-war-plugin need: * source paths (libraries & src/main/webapp) -> exploded war -> build archive Many files need be copied to exploded war directory. To speed up the maven-war-plugin, I would like to propose below solution: * source paths (libraries & src/main/webapp) -> build archive Here when "-Dmaven.war.exploded.skip=true" is passed, the maven-war-plugin then build the archive directly based on all source paths. maven.war.exploded.skip is by default set as false as there might be a few cases user want an exploded war, for example: * Using tomcat7-maven-plugin to start exploded webapp I created the PR > Create war archive without creating exploded war > ------------------------------------------------ > > Key: MWAR-445 > URL: https://issues.apache.org/jira/browse/MWAR-445 > Project: Maven WAR Plugin > Issue Type: Improvement > Components: manifest > Affects Versions: 3.3.2 > Reporter: wei cai > Priority: Minor > > Currently to build a war archive, maven-war-plugin need: > * source paths (libraries, src/main/webapp...) -> exploded war -> build > archive > Many files need to be copied to exploded war directory before creating war > archive. > To speed up the maven-war-plugin, I would like to propose below solution: > * source paths (libraries, src/main/webapp...) -> build archive > Here when "-Dmaven.war.exploded.skip=true" is passed, the maven-war-plugin > then build the archive directly based on all source paths, in this way, > massive file copying can be avoided. > maven.war.exploded.skip is by default set as false as there might be a few > cases user want an exploded war, for example: > * Using tomcat7-maven-plugin to start exploded webapp > > I created the PR: [https://github.com/apache/maven-war-plugin/pull/21] for > initial discussion. > Please help review and advise: > * Does it make sense to skip the creation of exploded war? Any features will > break because of this? > * Regarding the ITs, shall I separate the tests into 2 scenarios? > ** ITs for original behavior. > ** ITs for building war archive without creating exploded war. > -- This message was sent by Atlassian Jira (v8.20.1#820001)