Lonzak edited a comment on pull request #107: URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971342688
I don't think it is a noop even though the default is false. > threadSafe - @threadSafe <true\|false> - Default: false > Marks this mojo as being thread-safe, i.e. the mojo safely supports concurrent execution during parallel builds. **Mojos without this annotation will make Maven output a warning when used during a parallel build session.** The short-hand notation @threadSafe without a tag value is equivalent to @threadSafe true. So when you specify the tag and set it to false there will be **no** warning. Maven and developers know that the plugin is not thread safe. Basically: Case1: no annotation: **Warning printed**, should be no parallel execution (but there are certain constellations I have doubts about this since we had problems before. But might have been a bug in maven itself interpreting the threadSafe annotation or a missing one) Case2: annotation set to false = **No warning**, no parallel execution Case3: annotation set to true = **No warning**, parallel execution Thus it doesn't look like a noop to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
