Giovds commented on a change in pull request #586:
URL: https://github.com/apache/maven/pull/586#discussion_r727886446



##########
File path: maven-core/pom.xml
##########
@@ -212,9 +220,7 @@ under the License.
         <artifactId>modello-maven-plugin</artifactId>

Review comment:
       The `<models></models>` attribute is unfortunately a 
[required](https://codehaus-plexus.github.io/modello/modello-maven-plugin/generate-mojo.html)
 element in the plugin configuration, therefore it can not be removed. This 
plugin needs to stay, because of the `modello-site-doc` execution. However 
[that 
model](https://github.com/apache/maven/blob/0080e845884922814d26914d0ae9f59b084bee35/maven-core/src/main/mdo/extension.mdo#L33)
 must explicitly not generate java code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to