[ 
https://issues.apache.org/jira/browse/MNG-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426567#comment-17426567
 ] 

lujie commented on MNG-7293:
----------------------------

https://github.com/apache/maven/pull/574

> Resource Leak due to Files.walk
> -------------------------------
>
>                 Key: MNG-7293
>                 URL: https://issues.apache.org/jira/browse/MNG-7293
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: lujie
>            Priority: Major
>
> see 
> [https://github.com/apache/maven/blob/d75bea415457b2eba7815bb9c3e9cd4e14b47fce/maven-wrapper/src/main/java/org/apache/maven/wrapper/Installer.java#L143]
>  
> Stream creates by File.walk should be closed, like jdk said:
> * <p> The returned stream encapsulates one or more \{@link DirectoryStream}s.
>  * If timely disposal of file system resources is required, the
>  * \{@code try}-with-resources construct should be used to ensure that the
>  * stream's \{@link Stream#close close} method is invoked after the stream
>  * operations are completed. Operating on a closed stream will result in an
>  * \{@link java.lang.IllegalStateException}.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to