[ 
https://issues.apache.org/jira/browse/MNG-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425105#comment-17425105
 ] 

Michael Osipov commented on MNG-6762:
-------------------------------------

bq. [~michael-o], for all these years I have been totally confused, thanks for 
the clarification. Also I have missed somehow all of the "always" and "should" 
in the Karl Heinz Marbaise's explanation above.

I guess this is missing in our documentation. Feel free to raise a PR in the 
docs which should be improved. It is too late to rename those files already. 
Maybe in Maven 5 side by side. Bad names can really cause confusion. Also here, 
you can raise a discussion on the mailing list denoting that {{.config}} is 
just wrong.

bq. So, is it right that the only correct way to build separate modules of a 
multi module project is to execute {{mvn -pl ModuleName}} from the root of the 
project, and never from a module sub-directory? If it is, then {{mvn}}, 
perhaps, may give some warning in the latter case.

Correct, always use that approach in a reactor build. Nothing else. A module is 
incomplete without its local parent. The problem with that warning is that, I 
think, there is no 100% way to make sure that this is really a reactor build 
which requires to build from top (could also be an aggregator) and what if the 
parent does not contain a {{.mvn}} dir? How to reliably detect? Before we issue 
a deceiving warning, rather give none.

> Multimodule project with .mvn/settings.xml not working properly
> ---------------------------------------------------------------
>
>                 Key: MNG-6762
>                 URL: https://issues.apache.org/jira/browse/MNG-6762
>             Project: Maven
>          Issue Type: Improvement
>    Affects Versions: 3.5.4
>            Reporter: Morten Minke
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I have a project with the following setup:
>  
> {noformat}
> - MyProject
>   |- .mvn
>   |  |- maven.config
>   |  |- settings.xml
>   |- MyModule1
>   |  |- pom.xml
>   |- MyModule2
>   |  |- pom.xml
>   |- pom.xml{noformat}
>  
> The .mvn/maven.config file contains the following:
> {noformat}
> ..
> --settings .mvn/settings.xml{noformat}
> With this setup, I cannot build the modules separately because it cannot find 
> the .mvn/settings.xml file in the MyModule1 directory.
>  
> I looked into the code and saw that in the mvn script, the .mvn folder is 
> searched for in the parent folders. If it is found, that folder is marked as 
> the 'maven.multiModuleProjectDirectory'.
>  
> However, as soon as the configuration is loaded, this 
> multiModuleProjectDirectory is not used anymore for the interpretation of the 
> --settings property, therefor maven tries to find the .mvn/settings.xml file 
> inside the MyModule1 folder where it is not found.
> This results in an Exception and termination of Maven.
>  
> I thought of a couple of ways this could be solved:
>  * Allow for a variable substitution to work in the maven.config file and 
> thus reference something like:
> {noformat}
> ..
> --settings ${baseDir}/.mvn/settings.xml{noformat}
>  * When the maven.multiModuleProjectDirectory is configured and the 
> --settings flag is a relative directory, than use the 
> maven.multiModuleProjectDirectory as the root to obtain the settings.xml file.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to