michael-o commented on a change in pull request #125:
URL: https://github.com/apache/maven-scm/pull/125#discussion_r705632908
##########
File path:
maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/util/StarteamUtil.java
##########
@@ -65,16 +65,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/PerforceScmProvider.java
##########
@@ -433,16 +433,11 @@ private static String generateDefaultClientspecName(
ScmLogger logger, PerforceS
hostname = InetAddress.getLocalHost().getHostName();
// [SCM-370][SCM-351] client specs cannot contain forward slashes,
spaces and ~; "-" is okay
path = workDir.getCanonicalPath().replaceAll( "[/ ~]", "-" );
- }
- catch ( UnknownHostException e )
+ } catch ( IOException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/PerforceWhereCommand.java
##########
@@ -149,23 +149,14 @@ public String getDepotLocation( String filepath )
return path;
}
- catch ( CommandLineException e )
+ catch ( CommandLineException | IOException e )
{
if ( logger.isErrorEnabled() )
{
logger.error( e );
}
throw new RuntimeException( e.getLocalizedMessage() );
- }
- catch ( IOException e )
- {
- if ( logger.isErrorEnabled() )
- {
- logger.error( e );
- }
- throw new RuntimeException( e.getLocalizedMessage() );
- }
- finally
+ } finally
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-provider-clearcase/src/main/java/org/apache/maven/scm/provider/clearcase/util/ClearCaseUtil.java
##########
@@ -82,16 +82,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
{
// nop
- }
- catch ( IOException e )
- {
- // nop
- }
- catch ( XmlPullParserException e )
+ } catch ( XmlPullParserException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-provider-clearcase/src/main/java/org/apache/maven/scm/provider/clearcase/util/ClearCaseUtil.java
##########
@@ -82,16 +82,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-provider-perforce/src/main/java/org/apache/maven/scm/provider/perforce/command/PerforceInfoCommand.java
##########
@@ -153,15 +153,10 @@ protected ScmResult executeCommand( ScmProviderRepository
repo, ScmFileSet scmFi
}
}
}
- catch ( CommandLineException e )
+ catch ( CommandLineException | IOException e )
{
throw new ScmException( e.getLocalizedMessage() );
- }
- catch ( IOException e )
- {
- throw new ScmException( e.getLocalizedMessage() );
- }
- finally
+ } finally
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-provider-vss/src/main/java/org/apache/maven/scm/provider/vss/commands/VssCommandLineUtils.java
##########
@@ -138,16 +138,10 @@ public static Settings readSettings()
try
{
settings = reader.read( ReaderFactory.newXmlReader(
settingsFile ) );
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/main/java/org/apache/maven/scm/provider/cvslib/util/CvsUtil.java
##########
@@ -67,16 +67,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
- {
- // skip error
- }
- catch ( IOException e )
+ } catch ( IOException e )
{
// skip error
- }
- catch ( XmlPullParserException e )
+ } catch ( XmlPullParserException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/util/GitUtil.java
##########
@@ -66,16 +66,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/util/SvnUtil.java
##########
@@ -65,16 +65,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/util/GitUtil.java
##########
@@ -66,16 +66,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
{
//Nothing to do
- }
- catch ( IOException e )
- {
- //Nothing to do
- }
- catch ( XmlPullParserException e )
+ } catch ( XmlPullParserException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-provider-starteam/src/main/java/org/apache/maven/scm/provider/starteam/util/StarteamUtil.java
##########
@@ -65,16 +65,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
{
// nop
- }
- catch ( IOException e )
- {
- // nop
- }
- catch ( XmlPullParserException e )
+ } catch ( XmlPullParserException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/main/java/org/apache/maven/scm/provider/cvslib/util/CvsUtil.java
##########
@@ -67,16 +67,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
- {
- // skip error
- }
- catch ( IOException e )
+ } catch ( IOException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-provider-vss/src/main/java/org/apache/maven/scm/provider/vss/commands/VssCommandLineUtils.java
##########
@@ -138,16 +138,10 @@ public static Settings readSettings()
try
{
settings = reader.read( ReaderFactory.newXmlReader(
settingsFile ) );
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
{
// nop
- }
- catch ( IOException e )
- {
- // nop
- }
- catch ( XmlPullParserException e )
+ } catch ( XmlPullParserException e )
Review comment:
Here
##########
File path:
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/util/SvnUtil.java
##########
@@ -65,16 +65,10 @@ public static Settings readSettings()
try
{
return reader.read( ReaderFactory.newXmlReader( settingsFile )
);
- }
- catch ( FileNotFoundException e )
+ } catch ( IOException e )
{
//Nothing to do
- }
- catch ( IOException e )
- {
- //Nothing to do
- }
- catch ( XmlPullParserException e )
+ } catch ( XmlPullParserException e )
Review comment:
Here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
