kriegaex commented on pull request #104:
URL:
https://github.com/apache/maven-shade-plugin/pull/104#issuecomment-882955253
@Tibor17, if you take time to read our discussion above, you will see that
opinions are diverging about the scope of this PR and the connected Jira issue.
While I think it is complete and a new issue should be created for what
@rmannibucau wants, he argues that
* functionality should be extended to cover handling directories and/or
* here the existence of a directory in the classpath as such is a smell
which should be fixed while building/filtering the cp, and not issuing a
warning is covering up that problem.
Maybe you two guys can figure out together what you want to do here. Just
please do not let this PR rot. Either add commits here (I allowed it in the PR
settings) or create a new PR with what you believe is the real solution. Or
merge it and simultaneously create a new issue, specifying what needs to be
done to improve the situation further. Then nothing is covered up or forgotten.
Just please give users a chance to not having to see this warning anymore. It
gets on everyone's nerves, and users are afraid they made a mistake, which they
didin't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
