antoniolucasnobar commented on a change in pull request #135: URL: https://github.com/apache/maven-dependency-plugin/pull/135#discussion_r668032985
########## File path: src/main/java/org/apache/maven/plugins/dependency/filters/AbstractDependencyFilter.java ########## @@ -0,0 +1,50 @@ +package org.apache.maven.plugins.dependency.filters; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.HashSet; +import java.util.Locale; +import java.util.Set; + + +abstract class AbstractDependencyFilter implements DependencyFilter Review comment: Created the PR to your branch: https://github.com/apache/maven-dependency-plugin/pull/145 Should I change anything else? There is a apparently unfinished thread about package names in June 1st. Do I have to sign any documents? Please let me know. PS.: I am sorry, butI did not understand why you are thinking in close this PR. Which goals are you talking about? Should they be a part in this PR? I think this PR solves the go-offline problem, which is the subject of MDEP-568. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
