[
https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376209#comment-17376209
]
Alexander Kriegisch commented on MCHECKSTYLE-406:
-------------------------------------------------
Thanks for your advice. Of course, it is an AspectJ Maven build, but what I
said is true anyway: We do not use any specific config file there. We also have
no wish to do so. We transparently use the default config from
maven-shared-resources, which you were friendly enough to link to. We simply
rely on that default config to work for us, we do not have any special needs
there. We just use the plugin and are fine with the default Checkstyle version.
No complaints at all. Like I said, this is in no way urgent. I just reacted on
the Dependabot PR, checking the build log and decided to report that the latest
Checkstyle versions do not fit with the current plugin version when using the
default config. Nowhere did I say that this is a bug or your fault or that it
even needs to be fixed in this project, if you think that the fix might be
better done in Maven Shared Resources. Calm down, please, there is no blame
here. So there is no need to be so defensive either. You mad no mistake.
I know nothing whatsoever about Checkstyle. I simply followed the guide for
this plugin, which I linked to before, upgrading Checkstyle according to the
description there. My expectation is that in a future version, just like with
this one, if I upgrade the plugin and it supports the latest Checkstyle
version, it works with the default config taken from Maven Shared Resources. I
hope it is OK to ask you if you can talk to the maintainers of the Shared
Resources, whenever you think is the appropriate time, and come to an agreement
with them to upgrade Checkstyle and the default config there in sync, so that
it simply works for users.
Again: This is not a bug report, because there is no bug. It is simply a
request to take the breaking changes in Checkstyle into account when upgrading
both this plugin and the shared resources next time. We are talking about a
future version here, not about the current one. I can wait. AspectJ Maven does
not use Checkstyle 8.42+, we use 8.41.1 and are fine for now. Only the
Dependabot PR suggests the update, but the PR is unmerged. So no harm was done
at all. Thank you very much.
> Make plugin compatible with Checkstyle 8.44
> -------------------------------------------
>
> Key: MCHECKSTYLE-406
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-406
> Project: Maven Checkstyle Plugin
> Issue Type: Dependency upgrade
> Affects Versions: 3.1.2
> Reporter: Alexander Kriegisch
> Priority: Major
>
> On GitHub, Dependabot suggests upgrading Checkstyle to something more recent
> than 8.41.1, but the corresponding builds fail, both for 8.43 and 8.44, e.g.
> [this
> build|https://github.com/dev-aspectj/aspectj-maven-plugin/pull/20/checks?check_run_id=2933248023]:
> {code}
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on
> project aspectj-maven-plugin: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report: Failed during checkstyle
> configuration: cannot initialize module TreeWalker - cannot initialize module
> JavadocMethod - Property 'scope' does not exist, please check the
> documentation -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on
> project aspectj-maven-plugin: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> (...)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating
> maven-checkstyle-plugin:3.1.2:checkstyle report
> at org.apache.maven.plugins.site.render.SiteMojo.execute
> (SiteMojo.java:151)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> (...)
> Caused by: org.apache.maven.reporting.MavenReportException: Failed during
> checkstyle configuration
> at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure
> (AutomaticBean.java:201)
> at
> org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
> (DefaultCheckstyleExecutor.java:167)
> at
> org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport
> (AbstractCheckstyleReport.java:533)
> (...)
> {code}
> This is in no way urgent, but as Dependabot keeps bugging me with this for
> every new Checkstyle version, I thought I should mention it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
