[
https://issues.apache.org/jira/browse/DOXIA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353958#comment-17353958
]
ASF GitHub Bot commented on DOXIA-588:
--------------------------------------
qualitesys commented on a change in pull request #61:
URL: https://github.com/apache/maven-doxia/pull/61#discussion_r642046393
##########
File path:
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java
##########
@@ -1658,6 +1659,35 @@ public void tableHeaderCell( SinkEventAttributes
attributes )
private void tableCell( boolean headerRow, MutableAttributeSet attributes )
{
Tag t = ( headerRow ? HtmlMarkup.TH : HtmlMarkup.TD );
+
+ if ( !headerRow
+ && null != this.cellCountStack
Review comment:
Starting with constants in logical expressions prevents from a very
common mistakes that can be very tricky, this concerns Java, C, C++, C# att
least.
See [https://cwe.mitre.org/data/definitions/481.html](url)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The Sink.JUSTIFY_XXX has no effect
> ----------------------------------
>
> Key: DOXIA-588
> URL: https://issues.apache.org/jira/browse/DOXIA-588
> Project: Maven Doxia
> Issue Type: Bug
> Reporter: QualiteSys QualiteSys
> Assignee: Sylwester Lachiewicz
> Priority: Minor
> Fix For: 1.10
>
>
> Hello
> I wish to use custom column alignments in tables.
> The Sink.JUSTIFY_LEFT or RIGHT seams not working.
>
> Is this code valid ?
> {code:java} sink.table();
> int[] j = {
> Sink.JUSTIFY_LEFT,
> Sink.JUSTIFY_RIGHT
> };
> sink.tableRows(j, true);{code}
> I haven't found examples up to now.
> Thanks for your help
> Didier
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
