[GitHub] [maven-javadoc-plugin] bmarwell commented on a change in pull request #67: [MJAVADOC-619] Maven Javadoc bottom claims copyright for future years

[GitBox]

bmarwell commented on a change in pull request #67:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/67#discussion_r624539285



##########
File path: 
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -2954,8 +2959,18 @@ private void populateCompileArtifactMap( Map<String, 
Artifact> compileArtifactMa
      */
     private String getBottomText()
     {
-        int currentYear = Calendar.getInstance().get( Calendar.YEAR );
-        String year = String.valueOf( currentYear );
+        final String year;
+        String buildTime = project.getProperties().getProperty( 
"project.build.outputTimestamp" );
+        if ( buildTime != null )
+        {
+            year = String.valueOf( DateTimeFormatter.ISO_DATE_TIME.parse( 
buildTime ).get( ChronoField.YEAR ) );
+        }
+        else
+        {
+            getLog().debug( "Missing property project.build.outputTimestamp, 
using current year instead" );

Review comment:
       "missing" sounds like a warning. Maybe instead use "property xyz is not 
set, using..."?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org