[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #344: SUREFIRE-1854 Support include/exclude junit test engine

[GitBox]

Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r607851990



##########
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1571,13 +1566,15 @@ private void convertGroupParameters()
 
     private void convertJunitEngineParameters()
     {
-        if ( isNotBlank( getJunitIncludeEngine() ) )
+        if ( getIncludeJUnit5Engines() != null )
         {
-            getProperties().setProperty( JUNIT_INCLUDE_ENGINE_PROP, 
getJunitIncludeEngine() );
+            String includeJUnit5Engines = Arrays.toString( 
getIncludeJUnit5Engines() ).replaceAll( "\\[\\]", "" );

Review comment:
       Pls do not use `Arrays.toString`. Nobody does this way. Use a typical 
loop. In Java 8 we will have string joinrer but now pls use a loop and 
StringBuilder.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org