michael-o commented on pull request #77:
URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-813441893


   > 
   > 
   > General remark: my personal preference for local variables is to declare 
them as they are, so `Type variable = new Type()`, in cases when the variable 
is strictly local scoped. I really see no value in doing `Supertype variable = 
new Type()` when the `variable` is used in local scope only. Is not only more 
logical to me, but lessens import count as well (Type vs Supertype in example 
above).
   
   I understand your position, but have you looked how the overall code looks 
like? It is using supertypes (interfaces) only. I'd like to keep the codebase 
consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to