[
https://issues.apache.org/jira/browse/SUREFIRE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312064#comment-17312064
]
Patrick Reinhart edited comment on SUREFIRE-1881 at 3/31/21, 5:15 AM:
----------------------------------------------------------------------
[~kriegaex] this i already incorporated into my [PR
#353|https://github.com/apache/maven-surefire/pull/343] which is also referred
in this issue. See my [comment from march
30th.|https://issues.apache.org/jira/browse/SUREFIRE-1881?focusedCommentId=17311821&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17311821]
But this itself is *not* the solution for the hanging main Maven process. The
fix for this, I added as described in the [comment from march
31th|https://issues.apache.org/jira/browse/SUREFIRE-1881?focusedCommentId=17312037&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17312037]
to the already existing PR.
My aim is to help get this issue fixed too as it is your goal, so please read
also my comments (not just complaining about not understood comments from your
side...)
Having all that said, the fix is not jet complete as I need to dig deeper into
the inter process communication, as the completion signal from the forked
process ({{ForkedBooter.acknowledgedExit()}} method) somehow not getting the
way back to the {{ForkStarter}}...
was (Author: reinhapa):
[~kriegaex] this i already incorporated into my [PR
#353|https://github.com/apache/maven-surefire/pull/343] which is also referred
in this issue. See my [comment from march
30th.|https://issues.apache.org/jira/browse/SUREFIRE-1881?focusedCommentId=17311821&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17311821]
But this itself is *not* the solution for the hanging main Maven process. The
fix for this, I added as described in the [comment from march
31th|https://issues.apache.org/jira/browse/SUREFIRE-1881?focusedCommentId=17312037&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17312037]
to the already existing PR
My aim is to help get this issue fixed too as it is your goal, so please read
also my comments (not just complaining about not understood comments from your
side...)
> Java agent printing to native console makes build block when using
> SurefireForkNodeFactory
> ------------------------------------------------------------------------------------------
>
> Key: SUREFIRE-1881
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1881
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin
> Affects Versions: 3.0.0-M5
> Reporter: Alexander Kriegisch
> Assignee: Tibor Digana
> Priority: Major
> Attachments: Bildschirmfoto von 2021-03-29 21-50-25.png,
> image-2021-02-08-12-07-34-183.png, image-2021-03-26-09-48-11-398.png,
> image-2021-03-26-09-52-36-881.png, image-2021-03-26-18-00-37-889.png,
> image-2021-03-31-11-22-50-682.png, image-2021-03-31-11-38-11-119.png,
> maven-failsafe-debug-log.txt, screenshot-1.png, screenshot-2.png
>
>
> This is a follow-up to SUREFIRE-1788 which was closed prematurely even though
> there still were open issues which were discussed there initially. Basically
> the situation is as follows:
> * I use Java agents writing to stdOut and stdErr in my tests.
> * I was annoyed that Surefire/Failsafe were writing lots of {{[WARNING]
> Corrupted STDOUT by directly writing to native stream in forked JVM}} lines
> into {{*-jvmRun1.dumpstream}} files. [~tibordigana] then told me to use
> {{<forkNode
> implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>}}
> in my POM in order to fix the issue.
> * I tried this in version 3.0.0-M5, but unfortunately, it makes
> Surefire/Failsafe freeze if a Java agent prints something to stdOut or
> stdErr. This happens both in M5 and in M6-SNAPSHOT after both SUREFIRE-1788
> and SUREFIRE-1809 have been merged in already.
> * My [sample
> project|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems]
> reproduces the issue as soon as you uncomment the option in the POM and run
> {{mvn clean verify}}.
> * The second issue is: *Not* using this option leads to garbled log output
> when a Java agent writes to both stdOut and stdErr before/during tests. See
> comments in class
> [{{Agent.DummyTransformer}}|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/src/main/java/de/scrum_master/dummy/Agent.java]
> for examples for garbled log lines and also comments in
> [pom.xml|https://github.com/kriegaex/Maven_Surefire_PrintToConsoleProblems/blob/master/pom.xml#L36]
> for further information.
> * If the garbled output would also appear with this option activated, cannot
> be tested at present due to the Surefire/Failsafe freeze. I will re-test that
> after the freeze has been fixed and before this issue can be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
