[ 
https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290758#comment-17290758
 ] 

Herve Boutemy commented on MNG-7051:
------------------------------------

I just found an unexpected side effect of this feature: it now refuses some 
profile ids like "java9+" = a profile id used in Apache Camel

I see that profile id is now checked like any other id: 
https://github.com/apache/maven/commit/8defd169651db30fe0ac3ad3f318e471f0241d02#diff-690df442061d3325c6a7cf7b687e90ae79dd3639d45b8d1e606ad1bbc97a00e2

I'm not sure this is the best solution:
- too aggressive for example with this "+"
- not sufficiently aggressive if a profile is named 
"-profile_cannot_be_activated"

should I create a separate Jira issue?

> Optionally skip non-existing profiles
> -------------------------------------
>
>                 Key: MNG-7051
>                 URL: https://issues.apache.org/jira/browse/MNG-7051
>             Project: Maven
>          Issue Type: Sub-task
>          Components: Profiles
>            Reporter: Maarten Mulders
>            Assignee: Martin Kanters
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> For Maven 4, the behaviour of the {{-P}} command line option will change:
>  * {{-P apache-release}} will activate the *apache-release* profile. If such 
> a profile cannot be found, the build will break.
>  * {{-P ?apache-release}} will activate the *apache-release* profile. If such 
> a profile cannot be found, the build will continue but log a warning.
> {color:#ff0000}
> Note that this breaks the current behaviour of Maven 3 in two ways:
> {color}
> # {{-P apache-release}} will currently log a warning and not break the build. 
> That behaviour can be restored by adding the {{?}}.
> # A profile that has an identifier that not valid (i.e., contains anything 
> else than {{a}} - {{z}}, {{A}} to {{Z}}, {{0}} - {{9}}, {{-}}, {{_}} or 
> {{.}}) will break the build.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to