michael-o commented on a change in pull request #446: URL: https://github.com/apache/maven/pull/446#discussion_r575836052
########## File path: maven-core/src/main/java/org/apache/maven/execution/ProfileActivation.java ########## @@ -74,7 +44,7 @@ static ActivationSettings of( final boolean active, final boolean optional ) @Deprecated public List<String> getActiveProfiles() { - return new ArrayList<>( getProfileIds( pa -> pa.active ) ); + return Collections.unmodifiableList( new ArrayList<>( getProfileIds( pa -> pa.active ) ) ); Review comment: Agreed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org