[GitHub] [maven] MartinKanters commented on a change in pull request #429: [MNG-7051] - Optionally skip non-existing profiles and break on missing required profiles

[GitBox]

MartinKanters commented on a change in pull request #429:
URL: https://github.com/apache/maven/pull/429#discussion_r565151353



##########
File path: 
maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
##########
@@ -358,16 +352,18 @@ public MavenExecutionRequest setInactiveProfiles( 
List<String> inactiveProfiles
     {
         if ( inactiveProfiles != null )
         {
-            this.inactiveProfiles = new ArrayList<>( inactiveProfiles );
-        }
-        else
-        {
-            this.inactiveProfiles = null;
+            this.profileActivation.overwriteInactiveProfiles( inactiveProfiles 
);
         }
 
         return this;
     }
 
+    @Override
+    public ProfileActivation getProfileActivationRequest()

Review comment:
       This was a leftover after processing Robert's comment: 
https://github.com/apache/maven/pull/429#discussion_r554032511. 
   My bad, will rename accordingly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org