mkarg commented on pull request #421:
URL: https://github.com/apache/maven/pull/421#issuecomment-765974428


   Guys, don't get me wrong, but for the sake of finding a concensus, maybe we 
should agree on two things:
   
   (1) We do *not* insist on personally wanted changes *must* be done unless 
there is a technical fault or *actual* (not *assumed*) risk that *we all* agree 
that it really exists. Which is not the case here so far, as @elharo insists on 
KEEPING a test while @rmannibucau plead for DISCARDING it. So apparently, it is 
NOT ESSENTIAL to have that particular test, so we should not keep it.
   
   (2) We separate the discussion about what is *wrong* (i. e. *proven* to fail 
with the currrent code) from what one thinks *could* be tested *in addition* 
(like testing particular use cases instead of the actual contributed code). The 
proof @elharo insists upon is NOT ESSENTIAL, so it CANNOT be showstopper for 
this PR, but it just can be a good and valuable *proposal for addition ontop* 
in a further PR.
   
   I respect all you opinions, but this whole discussion seems to be more about 
personal visions what we could add *ontop* of my PR, or person vision what 
valid use cases for mocks and spies are, but not about the PR's actual status 
itself. Or at least, I have not yet understood what is actually and proven 
*wrong* in my PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to