gnodet commented on pull request #431:
URL: https://github.com/apache/maven/pull/431#issuecomment-760920854


   There are also a few tests that actually do not work:
   
https://github.com/gnodet/maven/commit/5bc542fce94ec873f503e9e127fbfd9d46d3a11d#diff-b8f35d04005261b9de1033f5d6470eb58437c6c738c13819526de6e1fb3454f5R208-R215
   In the above example, the `new DefaultArtifactVersion( "..." )` does not 
actually throw an exception.  I assumed this was expected given the assertion 
in the catch, so I ended up disabling the test.  There are a few occurences of 
those.  Reviewing all `@Disabled` tests would be a good thing, but that's not 
the point of this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to