[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #33: [MEAR-166] Handling EAR modules of all types when modifying Class-Path and when skinnyWars / skinnyModules is used

[GitBox]

mabrarov commented on a change in pull request #33:
URL: https://github.com/apache/maven-ear-plugin/pull/33#discussion_r548752876



##########
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarMojo.java
##########
@@ -272,8 +272,8 @@ public void execute()
 
         // Now we have everything let's built modules which have not been 
excluded
         ScopeArtifactFilter filter = new ScopeArtifactFilter( 
Artifact.SCOPE_RUNTIME );
-        allJarModules = new ArrayList<JarModule>();
-        providedJarModules = new ArrayList<JarModule>();
+        allEarModules = new ArrayList<EarModule>();

Review comment:
       What's the reason old lines use `new ArrayList<JarModule>()`? Is it 
because they where written before migration to Java 7 as minimal supported 
version?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org