mabrarov commented on a change in pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#discussion_r505119592



##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -461,7 +461,7 @@ private void copyModules( final JavaEEVersion javaEEVersion,
                         getLog().info( "Copying artifact [" + module + "] to 
[" + module.getUri() + "]" );
                         FileUtils.copyFile( sourceFile, destinationFile );
 
-                        if ( skinnyWars && module.changeManifestClasspath() )
+                        if ( module.changeManifestClasspath() && ( skinnyWars 
|| module.getLibDir() == null ) )

Review comment:
       It looks that this change introduces non backward compatible behavior - 
modification of Class-Path entry of manifest - for SAR and HAR modules. Refer 
to pull request #24 which is going to fix that (with `false` default value of 
skinnyModules option). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to