elharo commented on a change in pull request #19:
URL: https://github.com/apache/maven-ear-plugin/pull/19#discussion_r501159098
##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -946,4 +946,27 @@ private void deleteOutdatedResources( final
Collection<String> outdatedResources
}
}
}
+
+ /**
+ * Searches for the given JAR module in the list of classpath elements and
if found matching returns index of
+ * class path element matching JAR module or -1 otherwise.
+ *
+ * @param classPathElements classpath elements to search among
+ * @param module module to find among classpath elements defined by {@code
classPathElements}
+ * @return -1 if {@code module} was not found in {@code classPathElements}
or index of item of
+ * {@code classPathElements} which matches {@code module}
+ */
+ private int findModuleInClassPathElements( final List<String>
classPathElements, final JarModule module )
Review comment:
The only place this is used, what's needed is a boolean. That is, you
care whether it's present or not. The position doesn't matter. Does it make
sense for this ti return a boolean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
