[GitHub] [maven-javadoc-plugin] allen-ball commented on pull request #58: MJAVADOC-661: Fix for tagletArtifact fails to scan multi-release JARs (MRJARs) for Taglets

[GitBox]

allen-ball commented on pull request #58:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/58#issuecomment-685786789


   I have added `src/it/projects/MJAVADOC-661_mrjar` which creates a 
multi-release JAR with a Taglet specific to each release between 9 and 
`${java.specification.version}`.  The test output *without* the fix is:
   
   ```
   ...
   [INFO] Building: MJAVADOC-661_mrjar/pom.xml
   [INFO] run post-build script verify.groovy
   [INFO]   The post-build script did not succeed. ['com.foo.Taglet9', 
'com.foo.Taglet10', 'com.foo.Taglet11',  not found]. Expression: 
(required.size() == 0)
   [INFO]           MJAVADOC-661_mrjar/pom.xml ....................... FAILED 
(13.8 s)
   ...
   [INFO] -------------------------------------------------
   [INFO] Build Summary:
   [INFO]   Passed: 68, Failed: 1, Errors: 0, Skipped: 3
   [INFO] -------------------------------------------------
   [ERROR] The following builds failed:
   [ERROR] *  MJAVADOC-661_mrjar/pom.xml
   [INFO] -------------------------------------------------
   ...
   ```
   
   I believe `src/test/resources/unit/tagletArtifacts-test` takes care of the 
Java 8 and before regressive case.
   
   Thanks for your consideration.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org