elharo commented on a change in pull request #59:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/59#discussion_r479642441
##########
File path:
src/test/resources/unit/fix-test/expected/src/main/java/fix/test/ClassWithJavadoc.java
##########
@@ -451,6 +451,21 @@ public void testException3()
{
throw new Exception();
}
+
+ /**
+ * to test if it will handle static final field correctly.
+ */
+ public static final int TEST_STATIC_FINAL_FIELD_0 = 1 << 2;
Review comment:
why the shift operators? This is a very surprising thing to see here.
##########
File path:
src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java
##########
@@ -1412,11 +1413,11 @@ private void addDefaultFieldComment( final StringWriter
stringWriter, final Java
// CHECKSTYLE_OFF: MagicNumber
if ( value.length() < 40 )
Review comment:
should this check the escaped length instead now, which could be longer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]