[ 
https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186794#comment-17186794
 ] 

George Gastaldi commented on MNG-6979:
--------------------------------------

[~michael-o] you mean the snippet in 
[https://github.com/vackosar/gitflow-incremental-builder/blob/23f36d0a70c5205b810c56e1247d4084b74168dc/src/main/java/com/vackosar/gitflowincrementalbuild/boundary/UnchangedProjectsRemover.java#L134-L144?|https://github.com/vackosar/gitflow-incremental-builder/blob/23f36d0a70c5205b810c56e1247d4084b74168dc/src/main/java/com/vackosar/gitflowincrementalbuild/boundary/UnchangedProjectsRemover.java#L134-L144]

I haven't run against the Maven Core ITs, but this change fixes the bug in my 
case.

> MavenSession.getCurrentProject may return an incorrect project in a 
> multimodule build
> -------------------------------------------------------------------------------------
>
>                 Key: MNG-6979
>                 URL: https://issues.apache.org/jira/browse/MNG-6979
>             Project: Maven
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.6.3
>            Reporter: George Gastaldi
>            Priority: Major
>         Attachments: project.zip
>
>
> Having an extension that just displays the current project, like in:
> {code:java}
> @Singleton
> @Named
> public class BuildModuleSelector extends AbstractMavenLifecycleParticipant {
>     @Inject
>     private Logger logger;
>     @Override
>     public void afterProjectsRead(MavenSession session) throws 
> MavenExecutionException {
>         logger.info(session.getCurrentProject().toString());
>         
> session.setProjects(Collections.singletonList(session.getCurrentProject()));
>     }
> }
> {code}
> Will fail to resolve the current project when executed in the root of a 
> project that depends on a module with the same parent.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to