pzygielo commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466589590



##########
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##########
@@ -279,6 +332,20 @@ public boolean isStreaming()
     private static final boolean SSL_ALLOW_ALL =
         Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall", 
"false" ) );
 
+    /**
+     * If enabled, then the content-type HTTP header will be set using the 
file extension
+     * or the stream header to determine the type, <b>disabled by default</b>
+     */
+    private static final boolean AUTOSET_CONTENT_TYPE =
+            Boolean.valueOf( System.getProperty( 
"maven.wagon.http.autocontenttype", "true" ) );

Review comment:
       I understand it's pattern copied from existing code - but why in new 
code not use `parseBoolean` instead of `valueOf` and skip unboxing?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to