[ 
https://issues.apache.org/jira/browse/SUREFIRE-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153429#comment-17153429
 ] 
Tibor Digana edited comment on SUREFIRE-1811 at 7/8/20, 9:34 AM:
-----------------------------------------------------------------

[~Pavel_K]
There are these alternatives:
1. main and test without {{module-info}} (classpath)
2. main with {{module-info}}, but test without {{module-info}} (main in 
modulepath and tests in classpath)
3. main and test with {{module-info}} (both in modulepath)

You can pickup the (2) option. Personally, i would choose that since i have one 
Java package.
If you want to test your framework from the user perspective then i would 
choose (3) because the user would never have the same package with the package 
of the framework in particular dependency and so the tests will have user's 
java packages different from the main impl...


was (Author: tibor17):
[~Pavel_K]
There are these alternatives:
1. main and test without {{module-info}} (classpath)
2. main without {{module-info}}, but test with {{module-info}} (main in 
modulepath and tests in classpath)
3. main and test with {{module-info}} (both in modulepath)

You can pickup the (2) option. Personally, i would choose that since i have one 
Java package.
If you want to test your framework from the user perspective then i would 
choose (3) because the user would never have the same package with the package 
of the framework in particular dependency and so the tests will have user's 
java packages different from the main impl...

> Add resources to JPMS test module
> ---------------------------------
>
>                 Key: SUREFIRE-1811
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1811
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Maven Failsafe Plugin
>    Affects Versions: 3.0.0-M5
>            Reporter: Pavel_K
>            Priority: Major
>
> I am testing version 3.0.0-M5 with two module-info in one project - one main 
> and one for test. My test project is here 
> https://github.com/PashaTurok/hibernate-h2-test4 . The problem is with 
> resources. For example, I have  src/main/resources/META-INF/persistence.xml 
> file that is not copied to test module. Because of this it is not possible to 
> find resource in test module and it is necessary to use something like this 
> https://github.com/PashaTurok/hibernate-h2-test4/blob/292e2e683ad72487cbf8d2e5a35dde0d9255001a/src/test/java/com/foo/hibernate/h2/test4/TestIT.java#L72
>  . 
> In target/test-classes/META-INF/jpms.args I see:
> {code:java}
> --patch-module
> my.project=/home/..../hibernate-h2-test4/src/main/java, 
> /home/.../hibernate-h2-test4/target/generated-sources/annotations
> {code}
> As I understand test module will NOT contain resources from the module under 
> test? I mean that test module will NOT contain 
> /home/..../hibernate-h2-test4/src/main/resources? 
> That's why I suggest to include src/main/resources in test module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to