[ 
https://issues.apache.org/jira/browse/MNG-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135472#comment-17135472
 ] 

Herve Boutemy commented on MNG-6562:
------------------------------------

IIUC, you want to warn at execution time on each plugin goal, instead of global 
approach at model building time: I suppose this can work
on a basic use, where user does {{mvn verify}}, he will get 3 plugins launching 
4 goals (2 compile goals, see 
https://maven.apache.org/ref/3.6.3/maven-core/default-bindings.html#Plugin_bindings_for_jar_packaging),
 then 3 or 4 separate warnings, missing install and deploy
if he runs {{mvn clean install}}, he will have in addition the clean warning

IMHO, this makes one unique issue feedback more dispersed across the run and 
discovery of the full scope of the issue later, but perhaps it seems less rude 
(or more hidden during run instead of boldly at the beginning).

and this does not help avoiding defining 7 plugins version as 7 
pluginManagement entries = what everybody will have to fix

> WARN if plugins injected by default lifecycle bindings don't have their 
> version locked in pom.xml or parent
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-6562
>                 URL: https://issues.apache.org/jira/browse/MNG-6562
>             Project: Maven
>          Issue Type: Improvement
>          Components: Plugins and Lifecycle
>    Affects Versions: 3.6.0
>            Reporter: Herve Boutemy
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: 3.7.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, when building from a basic pom.xml:
> {code:xml}<project>
>   <modelVersion>4.0.0</modelVersion>
>   <groupId>com.mycompany.app</groupId>
>   <artifactId>my-app</artifactId>
>   <version>1.0-SNAPSHOT</version>
> </project>{code}
> many plugins are used, but their version is not locked by the user: the 
> default plugins versions depend on Maven version used, which is not stable 
> over different Maven versions.
> Adding a warning for this stability issue will help users know that they need 
> to lock down plugins versions in their pom (or parent), something like:
> {noformat}[WARNING] 
> [WARNING] Some problems were encountered while building the effective model 
> for com.mycompany.app:my-app:jar:1.0-SNAPSHOT
> [WARNING] Version not locked for default bindings plugins 
> [maven-install-plugin, maven-resources-plugin, maven-surefire-plugin, 
> maven-compiler-plugin, maven-jar-plugin, maven-deploy-plugin, 
> maven-site-plugin], you should define versions in pluginManagement section of 
> your pom.xml or parent
> [WARNING] 
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING] 
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to