roxspring opened a new pull request #28:
URL: https://github.com/apache/maven-shared-utils/pull/28
- Added unit tests for `FileUtils.copyFile()` methods using `FilterWrapper`
- When filtering and _potentially_ overwriting an existing file:
- Open the existing file as a `RandomAccessFile`
- Encode each buffer of content
- Compare encoded buffer with a matching buffer from the existing file
- If different then overwrite the remainder of the file
- Added unit tests to demonstrate that lastModified date is only updated
when the content changes.
- Rudimentary performance tests with various source sizes show no
significant impact:
Source Size | Avg Millis (Old) | Avg Millis (New)
-- | -- | --
100 MB | 6034 | 5940
1 MB | 54 | 56
10 KB | 1 | 8
Relates to MSHARED-884
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
