elharo commented on a change in pull request #8:
URL: https://github.com/apache/maven-gpg-plugin/pull/8#discussion_r414063257
##########
File path: src/test/java/org/apache/maven/plugins/gpg/GpgVersionTest.java
##########
@@ -19,19 +19,30 @@
* under the License.
*/
+import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
-import org.apache.maven.plugins.gpg.GpgVersion;
import org.junit.Test;
+/**
+ * Tests for {@link GpgVersion}.
+ */
public class GpgVersionTest
{
@Test
public void test()
{
- assertTrue( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ).isAtLeast(
GpgVersion.parse( "gpg (GnuPG) 2.2.1" ) ) );
- assertTrue( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ).isAtLeast(
GpgVersion.parse( "2.1" ) ) );
- assertTrue( GpgVersion.parse( "gpg (GnuPG/MacGPG2) 2.2.10"
).isAtLeast( GpgVersion.parse( "2.2.10" ) ) );
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.2.1" )
+ .compareTo( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ) ), 0 );
+
+ assertTrue( GpgVersion.parse( "gpg (GnuPG) 2.2.1" )
+ .isAtLeast( GpgVersion.parse( "2.1" ) ) );
+
+ assertEquals( GpgVersion.parse( "gpg (GnuPG/MacGPG2) 2.2.10" )
+ .compareTo( GpgVersion.parse( "2.2.10" ) ), 0 );
+
+ assertEquals( GpgVersion.parse( "gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)" )
Review comment:
What I meant was these should have been three and now should be four
separate test methods with one assertion each.
The bug here was in parse, so we should be able to test that without using
compareTo.
Finally @rfscholte's comment suggests to me the equals method might not be
compatible with the comparable method which would be a bug bug if so.
Can the tests be rewritten to more directly address the bug at hand?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]