Tibor17 commented on a change in pull request #8:
URL: https://github.com/apache/maven-gpg-plugin/pull/8#discussion_r413839246
##########
File path: src/test/java/org/apache/maven/plugins/gpg/GpgVersionTest.java
##########
@@ -32,6 +34,8 @@ public void test()
assertTrue( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ).isAtLeast(
GpgVersion.parse( "gpg (GnuPG) 2.2.1" ) ) );
assertTrue( GpgVersion.parse( "gpg (GnuPG) 2.2.1" ).isAtLeast(
GpgVersion.parse( "2.1" ) ) );
assertTrue( GpgVersion.parse( "gpg (GnuPG/MacGPG2) 2.2.10"
).isAtLeast( GpgVersion.parse( "2.2.10" ) ) );
+ assertTrue( GpgVersion.parse( "gpg (GnuPG) 2.0.26 (Gpg4win 2.2.3)" )
Review comment:
i will change 3 because 3 should match equal version and one isAtLeast
version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]