rfscholte commented on a change in pull request #39: [MSHADE-353] adding a 
generic relocation friendly transformer
URL: https://github.com/apache/maven-shade-plugin/pull/39#discussion_r397480229
 
 

 ##########
 File path: src/site/apt/examples/resource-transformers.apt.vm
 ##########
 @@ -601,6 +603,45 @@ Transformers in 
<<<org.apache.maven.plugins.shade.resource>>>
 </project>
 +-----
 
+* Relocating file content with {RelocationTransformer}
+
+  The <<<RelocationTransformer>>> allows to apply relocators before delegating 
the processing to other transformers.
+
++-----
+<project>
+  ...
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-shade-plugin</artifactId>
+        <version>${project.version}</version>
+        <executions>
+          <execution>
+            <goals>
+              <goal>shade</goal>
+            </goals>
+            <configuration>
+              <transformers>
+                <transformer 
implementation="org.apache.maven.plugins.shade.resource.RelocationTransformer">
 
 Review comment:
   Maybe I'm missing an important detail, but in this example is no relocation. 
So why do it like this? 
   And I would have expected that defining both transformers after each other 
would work, but that requires defining the resource twice. That's probably the 
thing you're trying to solve.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to