Tibor17 commented on a change in pull request #240: [SUREFIRE-1658] TCP/IP
Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for
remote and local process communication.
URL: https://github.com/apache/maven-surefire/pull/240#discussion_r382901486
##########
File path:
surefire-booter/src/main/java/org/apache/maven/surefire/booter/BooterDeserializer.java
##########
@@ -58,6 +60,18 @@ public BooterDeserializer( InputStream inputStream )
properties = SystemPropertyManager.loadProperties( inputStream );
}
+ /**
+ * Describes the current connection channel used by the client in the
forked JVM
+ * in order to connect to the plugin process.
+ *
+ * @return connection string (must not be null)
+ */
+ @Nonnull
+ public String getConnectionString()
+ {
+ return properties.getProperty( FORK_NODE_CONNECTION_STRING );
Review comment:
@eolivelli
Now I have another idea. What about to inline the token in each response
going from JVM to the plugin? Currently we have this frame
`:maven-surefire-event:next-test:`. Whatabout to add the token into each frame?
Later we will have JSON (gson is small and still alive library) and we reduce a
lot of code/encoder using th JSON un/marshaller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
