[ 
https://issues.apache.org/jira/browse/SUREFIRE-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981255#comment-16981255
 ] 

Tibor Digana edited comment on SUREFIRE-1724 at 11/25/19 2:46 AM:
------------------------------------------------------------------

You mean that the Cucumber's Spec files are been looked up in target/classes?
This has to be configured then, right?


was (Author: tibor17):
You mean that the Cucumber has its own selector classes?
Why we did not simply use the fully qualified class name instead of this:

{code:java}
    private static Set<Path> classPathRootDiscoverySelectorFromConfiguration() {
        return Collections.singleton(new 
File("target/classes").getAbsoluteFile().toPath());
    }
{code}

Is it fast to look up in every Jar file?
I guess that the user would not code the selector by himself in 
{{target/classes}}.

> Support JUnit Platform DiscoverySelectors 
> ------------------------------------------
>
>                 Key: SUREFIRE-1724
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1724
>             Project: Maven Surefire
>          Issue Type: Improvement
>            Reporter: M.P. Korstanje
>            Priority: Major
>
> The JUnit Platform defines multiple 
> [DiscoverySelectors|https://junit.org/junit5/docs/5.0.2/api/org/junit/platform/engine/DiscoverySelector.html]
>  to discover tests in different locations. This allows TestEngines to 
> discover tests in classes, the class path root, resource root, files, ect.
> Currently Surefire supports TestEngine implementations  through the 
> JUnitPlatformProvider. However the JUnitPlatformProvider only issues 
> discovery requests for classes that have already been discovered by Surefire. 
> Additionally if no tests were discovered by Surefire then no test discovery 
> requests will be issued at all.
> This means that Surefire does not fully utilize the discovery capabilities of 
> the JUnit Platform and makes it impossible to use the JUnitPlatformProvider 
> for test frameworks that do not have class based tests such as Cucumber.
> To make Cucumber work at the very least the class path root discovery 
> selector would have to be supported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to