Tibor17 commented on a change in pull request #253: Fixes [SUREFIRE-1516]: Poor
performance in reuseForks=false
URL: https://github.com/apache/maven-surefire/pull/253#discussion_r345538857
##########
File path:
surefire-api/src/main/java/org/apache/maven/surefire/booter/CommandReader.java
##########
@@ -412,6 +412,10 @@ public void run()
CommandReader.this.wakeupIterator();
callListeners( command );
break;
+ case BYE_ACK:
+ //After SHUTDOWN no more commands can come.
Hence, do NOT go back to blocking in IO
+ callListeners( command );
+ return;
default:
callListeners( command );
Review comment:
Instead of calling the `return` we can make softer exit with
`CommandReader.this.state.set( TERMINATED )`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
