Tibor17 commented on a change in pull request #275: [MNG-6729]
StringSearchModelInterpolator introspects objects from Java API
URL: https://github.com/apache/maven/pull/275#discussion_r311742627
##########
File path: maven-model-builder/pom.xml
##########
@@ -84,6 +84,11 @@ under the License.
<artifactId>xmlunit-matchers</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
Developers know that test code uses a specific set of libraries which are
extremely specialized and some of them are Domain Specific in test area.
I have quite a lot of commercial experiences with writing Java tests but we
always have used Mockito, Powermock, AssertJ, Spock, etc. But we never mix the
domains.
Also we should use modern libraries for testing purposes as the same as Java
8 is juicy for a lot of contributors and me too! There's no difference with
the libs, and even more important to make the Maven code attractive for new
contributors. This means we wouldn't change the world with our internal coding
principals; instead we should adapt to the world, the sooner the better!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
