michael-o commented on issue #49: [MNG-2802] Concurrent-safe access to local Maven repository URL: https://github.com/apache/maven-wagon/pull/49#issuecomment-509382046 > It's been a long time since I had the ideas of this PR fresh in my mind, but do you think it would be worth implementing the same basic ideas in BasicRepositoryConnector instead? I have had zero look at that before, though, and it might be a while before I have time to check up on it. I think it is. You should take a look at `BasicRepositoryConnector` and tell what you think and how you could change that because putting anymore effort into it. If we can agree to some reasonable implementation you can take the take and update your PR. > You may very well be right about the LockableFileWriter now that I think about it, but the same principle should work fine with a BAOS and FileOutputStream or something. Correct, a `LockableFileOutputStream` might work as well. BAOS not because we could have gigabyte large files. > I understand your dislike for the System.exit() calls, but they are a convenient way to report status back to owning process, but of course some sort of stdout could be utilized instead. They shouldn't cause any harm though since whatever happens in the spawned process should be invisible to the containing JVM. I think this is our least problem, I noticed that they are scoped in the forked process so they cannot drown the Surefire VM.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
