josephw commented on a change in pull request #256: MNG-6685: convert maven-model-builder to JSR 330 URL: https://github.com/apache/maven/pull/256#discussion_r296268643
########## File path: maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerDocumentationTest.java ########## @@ -100,7 +101,7 @@ public String getOptionsAsHtml() public void testOptionsAsHtml() throws IOException { - File options = getTestFile( "target/test-classes/options.html" ); + File options = new File( "target/test-classes/options.html" ); Review comment: In this case, the test file is stored in that specific location, so setting `-Dbasedir` to anything else would cause the existing test to fail! It doesn't look like `basedir`'s being set anywhere for these tests, so that behaviour may not need to be carried over. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services