plamentotev edited a comment on issue #2: [MSOURCES-95] Fix source Jar is re-created even when sources are not changed URL: https://github.com/apache/maven-source-plugin/pull/2#issuecomment-503713580 It is interesting case. Actually the code works but the check fails. The test searches for the log messages that the jar is created and then that the jar is up to date: ``` // Make sure the jars are created on the first build assert buildLog.text.contains( " Building jar: ${sourcesJarFileName}" ) assert buildLog.text.contains( " Building jar: ${testSourcesJarFileName}" ) // Make sure the jars are not re-created on subsequent builds assert buildLog.text.contains( " Archive ${sourcesJarFileName} is uptodate" ) assert buildLog.text.contains( " Archive ${testSourcesJarFileName} is uptodate" ) ```` Unfortunately it looks like this does not work on Windows in some cases. The tests searches for `f:\jenkins\jenkins-slave\workspace\_maven-source-plugin_MSOURCES-95@2\windows-jdk7-m3.2.x_build\target\it\MSOURCES-95\target\empty-source-directory-1.0-SNAPSHOT-sources.jar` but in the logs it is `F:\jenkins\jenkins-slave\workspace\_maven-source-plugin_MSOURCES-95@2\windows-jdk7-m3.2.x_build\target\it\MSOURCES-95\target\empty-source-directory-1.0-SNAPSHOT-sources.jar`. Notice that the two are equal except for the capital `F`. In this case the two are equal as the case of the drive latter does not matter. I've modified the post build script to build the jar files names using file objects instead of concatenating strings. I think that this should fix it. @michael-o would you please try it again. Unfortunately it is not easy to reproduce it locally even on my Windows machine. If this solution does not work I'll use comparison that ignores the letters case.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
