minfrin commented on a change in pull request #5: Switch from XhtmlSink to
Xhtml5Sink as the default site renderer.
URL:
https://github.com/apache/maven-doxia-sitetools/pull/5#discussion_r290947982
##########
File path:
doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
##########
@@ -163,10 +163,12 @@ public void testRender()
SiteRenderingContext ctxt = getSiteRenderingContext( decoration,
"src/test/resources/site", false );
ctxt.setRootDirectory( getTestFile( "" ) );
+ renderer.copyResources( ctxt, getTestFile( OUTPUT ) );
Review comment:
Ran the test suite with these lines commented out, and got this:
SEVERE: Exception loading
file:/Users/minfrin/src/apache/sandbox/maven/maven-doxia-sitetools/doxia-site-renderer/target/output/css/maven-base.css
com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 404 Not
Found for
file:/Users/minfrin/src/apache/sandbox/maven/maven-doxia-sitetools/doxia-site-renderer/target/output/css/maven-base.css
The test suite still passes though - is this exception present in the
original code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
