[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835893#comment-16835893
 ] 

Enrico Olivelli commented on MCHECKSTYLE-363:
---------------------------------------------

I think you should only use pluginManagement in your parent pom

> Upgrading checkstyle at runtime in multi modules configuration
> --------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-363
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-363
>             Project: Maven Checkstyle Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Luc Maisonobe
>            Priority: Minor
>
> The documentation example "Upgrading Checkstyle at Runtime" shows how to
> select another version of the underlying checkstyle tool, but it doesn't work 
> in
> multi-modules configuration.
> The dependencies seem to not be inherited in multi-modules. With the 
> documentation as
> it exists now (for version 3.0.0, as of 2018-11-02), the checkstyle tool used 
> by children modules is the default one (i.e. 6.18 for 3.0.0 or 6.1.1 for 
> 2.17), and as the recent checkstyle tool configurations are incompatible with 
> pre 8.0 (mainly SuppressionCommentFilter which is now a child of TreeWalker), 
> the build fails.
> It would be nice to update the example documentation to add something like:
>     Note that in multi-modules configuration, putting the above setting in 
> parent pom
>    pluginManagement is not sufficient because dependencies are not inherited. 
> The
>    <dependency>...</dependency> must be copied in the pom of all modules. 
> Also as
>   the <reporting></reporting> section does not allow dependency settings, the
>   dependency settings must be set in a 
> <build><plugins><plugin>...</plugin></plugins></build> section in the 
> children pom.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to