rfscholte commented on a change in pull request #28: MRELEASE-985 Override
snapshot dependencies from command line
URL: https://github.com/apache/maven-release/pull/28#discussion_r281300548
##########
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/CheckDependencySnapshotsPhase.java
##########
@@ -309,7 +309,8 @@ private static boolean checkArtifact( Artifact artifact,
ReleaseDescriptor relea
// We are only looking at dependencies external to the project -
ignore anything found in the reactor as
// it's version will be updated
boolean result = artifact.isSnapshot()
- && !artifact.getBaseVersion().equals(
releaseDescriptor.getProjectOriginalVersion( versionlessKey ) );
+ && !artifact.getBaseVersion().equals(
releaseDescriptor.getProjectOriginalVersion( versionlessKey ) )
+ && releaseDescriptor.getDependencyReleaseVersion(
versionlessKey ) == null;
Review comment:
I see an issue here: users can pass a SNAPSHOT here and bypass the check.
This should not be allowed, so let's find the proper position to do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
