elharo commented on a change in pull request #234: [MNG-6572] - use int or long
instead of BigIntegers for little numbers in ComparableVersion
URL: https://github.com/apache/maven/pull/234#discussion_r268392207
##########
File path:
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
##########
@@ -238,10 +380,11 @@ public int compareTo( Item item )
return -1; // 1.any < 1-1
default:
- throw new RuntimeException( "invalid item: " +
item.getClass() );
+ throw new IllegalStateException( "invalid item: " +
item.getClass() );
Review comment:
OK, it's not really a Java type issue, I suppose. Perhaps Item should be an
enum and then this problem goes away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services