[ 
https://issues.apache.org/jira/browse/MJAVADOC-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MJAVADOC-570.
-----------------------------------
       Resolution: Fixed
         Assignee: Robert Scholte
    Fix Version/s: 3.1.0

Fixed in 
[c2681a49d246646b591281750ac0173d6f2f8834|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=c2681a49d246646b591281750ac0173d6f2f8834]
Thanks for the patch!


> --add-modules expects comma-separated arguments
> -----------------------------------------------
>
>                 Key: MJAVADOC-570
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-570
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>          Components: javadoc
>    Affects Versions: 3.1.0
>            Reporter: Gili
>            Assignee: Robert Scholte
>            Priority: Major
>             Fix For: 3.1.0
>
>
> It's quicker for me to explain this problem that produce a minimal testcase 
> for it. In AbstractJavadocMojo line 5079 we invoke:
> {code:java}
> addArgIfNotEmpty( arguments, "--add-modules", JavadocUtil.quotedPathArgument( 
> addModulesLine ) );{code}
> This gets converted to {{addArgIfNotEmpty()}} with {{splitValue=true}} which 
> means that comma-separated values get converted to newline-separated values. 
> {{--add-modules}} does not like this and does not consume the subsequent 
> arguments (they probably get treated as source files instead).
> We should be invoking {{addArgIfNotEmpty()}} with {{splitValue=false}} 
> instead.
> If I provide a PR for this, do you still need a testcase?
> On a side-note, it would really help if they documented the expected 
> behavior. I only ran across this by chance due to this bug report on OpenJDK: 
> [https://bugs.openjdk.java.net/browse/JDK-8165634] and when I converted 
> newline to commas in my own project one of the error messages went away.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to