[
https://issues.apache.org/jira/browse/MJAR-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744458#comment-16744458
]
Robert Scholte edited comment on MJAR-254 at 1/16/19 8:48 PM:
--------------------------------------------------------------
After having some discussions on the
[PR4|https://github.com/apache/maven-jar-plugin/pull/4] it looks like there's
no issue and it works as designs.
Correct me if I misunderstood the usecase:
- suppose you attach myproject-sources.jar (classifier {{sources}})
- next you attach generated-sources.jar (also classifier {{sources}}, but with
different finalName)
This is not possible, because during install/deploy the name for both will
become artifactId-version-classifier.type
So the second jar should get a different classifier or it shouldn't be attached.
was (Author: rfscholte):
After having some discussions on the
[PR4|https://github.com/apache/maven-jar-plugin/pull/4] it looks like there's
no issue and it works as designs.
Correct me if I misunderstood the usecase:
- suppose you attach myproject-sources.jar (classifier {{sources}})
- next you attach generated-sources.jar (also classifier {{sources}}, but with
different finalName)
This is not possible, because during install/deploy the name for both will
become artifactId-version-classifier.type
So the second jar should get a different classifier or it shouldn't be attached.
> The fix for MJAR-198 is incomplete: filename conflict not detected
> ------------------------------------------------------------------
>
> Key: MJAR-254
> URL: https://issues.apache.org/jira/browse/MJAR-254
> Project: Maven JAR Plugin
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Archie Cobbs
> Priority: Minor
> Labels: up-for-grabs
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See this comment on MJAR-198.
> In summary, the build should fail if the actual JAR file would get
> overridden, not if the classifier happens to be the same. That is, the
> conflict is at the actual filesystem level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
