eolivelli commented on a change in pull request #1: Manage default value in
filters
URL: https://github.com/apache/maven-filtering/pull/1#discussion_r245131561
##########
File path:
src/test/java/org/apache/maven/shared/filtering/MultiDelimiterInterpolatorFilterReaderLineEndingTest.java
##########
@@ -121,4 +123,25 @@ public void testAtDollarExpression()
assertEquals( " url=\"jdbc:oracle:thin:@DB_SERVER:DB_PORT:DB_NAME\"",
IOUtil.toString( reader ) );
}
+
+ @Test
+ public void testDefaultValue()
Review comment:
What about adding tests to cover syntax error cases? Or empty string as
default...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
