[jira] [Comment Edited] (MNG-5889) .mvn directory should be picked when using --file

Robert Patrick (JIRA) Fri, 21 Dec 2018 12:53:08 -0800


    [ 
https://issues.apache.org/jira/browse/MNG-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727045#comment-16727045
 ]


Robert Patrick edited comment on MNG-5889 at 12/21/18 8:52 PM:
---------------------------------------------------------------

So to me, this says that your issue has nothing to do with this issue and is 
somehow related to your use of the revision property.

Out of curiosity, I tried modifying an old project I had lying around to use 
the the revision property and it seems to be working fine--even with the 
-Drevision=xxx defined in maven.config.  Here is what I have:

weblogic-deploy-tooling\pom.xml:
{quote}
    <groupId>com.oracle.weblogic.lifecycle</groupId>
    <artifactId>weblogic-deploy</artifactId>
    <version>${revision}</version>
    <packaging>pom</packaging>
{quote}

weblogic-deploy-tooling/core/pom.xml:
{quote}
    <artifactId>weblogic-deploy-core</artifactId>

    <parent>
        <artifactId>weblogic-deploy</artifactId>
        <groupId>com.oracle.weblogic.lifecycle</groupId>
        <version>${revision}</version>
        <relativePath>../pom.xml</relativePath>
    </parent>
{quote}

weblogic-deploy-tooling\installer\pom.xml:
{quote}
    <artifactId>weblogic-deploy-installer</artifactId>
    <packaging>pom</packaging>

    <parent>
        <groupId>com.oracle.weblogic.lifecycle</groupId>
        <artifactId>weblogic-deploy</artifactId>
        <version>${revision}</version>
        <relativePath>../pom.xml</relativePath>
    </parent>

    <dependencies>
        <dependency>
            <groupId>${project.groupId}</groupId>
            <artifactId>weblogic-deploy-core</artifactId>
            <version>${project.version}</version>
        </dependency>
    </dependencies>
{quote}

And here is what happens:

{quote}
D:\projects>type weblogic-deploy-tooling\.mvn\maven.config
-Dunit-test-wlst-dir=c:/wls12213/oracle_common/common/bin
-Drevision=0.15

D:\projects>mvn --file weblogic-deploy-tooling\pom.xml validate
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Oracle WebLogic Server Deploy Tooling                              [pom]
[INFO] weblogic-deploy-core                                               [jar]
[INFO] weblogic-deploy-installer                                          [pom]
[INFO]
[INFO] -----------< com.oracle.weblogic.lifecycle:weblogic-deploy >------------
[INFO] Building Oracle WebLogic Server Deploy Tooling 0.15                [1/3]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-build-environment) @ 
weblogic-deploy ---
[INFO]
[INFO] ---------< com.oracle.weblogic.lifecycle:weblogic-deploy-core >---------
[INFO] Building weblogic-deploy-core 0.15                                 [2/3]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-build-environment) @ 
weblogic-deploy-core ---
[INFO]
[INFO] ------< com.oracle.weblogic.lifecycle:weblogic-deploy-installer >-------
[INFO] Building weblogic-deploy-installer 0.15                            [3/3]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-build-environment) @ 
weblogic-deploy-installer ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Oracle WebLogic Server Deploy Tooling 0.15:
[INFO]
[INFO] Oracle WebLogic Server Deploy Tooling .............. SUCCESS [  0.477 s]
[INFO] weblogic-deploy-core ............................... SUCCESS [  0.122 s]
[INFO] weblogic-deploy-installer .......................... SUCCESS [  0.019 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.784 s
[INFO] Finished at: 2018-12-21T14:48:21-06:00
[INFO] ------------------------------------------------------------------------

D:\projects>
{quote}



was (Author: rhpatrick00):
So to me, this says that your issue has nothing to do with this issue and is 
somehow related to your use of the revision property.

Out of curiosity, I tried modifying an old project I had lying around to use 
the the revision property and it seems to be working fine--even with the 
-Drevision=xxx defined in maven.config.  Here is what I have:

weblogic-deploy-tooling\pom.xml:
{{
    <groupId>com.oracle.weblogic.lifecycle</groupId>
    <artifactId>weblogic-deploy</artifactId>
    <version>${revision}</version>
    <packaging>pom</packaging>
}}

weblogic-deploy-tooling/core/pom.xml:
{{
    <artifactId>weblogic-deploy-core</artifactId>

    <parent>
        <artifactId>weblogic-deploy</artifactId>
        <groupId>com.oracle.weblogic.lifecycle</groupId>
        <version>${revision}</version>
        <relativePath>../pom.xml</relativePath>
    </parent>
}}

weblogic-deploy-tooling\installer\pom.xml:
{{
    <artifactId>weblogic-deploy-installer</artifactId>
    <packaging>pom</packaging>

    <parent>
        <groupId>com.oracle.weblogic.lifecycle</groupId>
        <artifactId>weblogic-deploy</artifactId>
        <version>${revision}</version>
        <relativePath>../pom.xml</relativePath>
    </parent>

    <dependencies>
        <dependency>
            <groupId>${project.groupId}</groupId>
            <artifactId>weblogic-deploy-core</artifactId>
            <version>${project.version}</version>
        </dependency>
    </dependencies>
}}

And here is what happens:

{quote}
D:\projects>type weblogic-deploy-tooling\.mvn\maven.config
-Dunit-test-wlst-dir=c:/wls12213/oracle_common/common/bin
-Drevision=0.15

D:\projects>mvn --file weblogic-deploy-tooling\pom.xml validate
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Oracle WebLogic Server Deploy Tooling                              [pom]
[INFO] weblogic-deploy-core                                               [jar]
[INFO] weblogic-deploy-installer                                          [pom]
[INFO]
[INFO] -----------< com.oracle.weblogic.lifecycle:weblogic-deploy >------------
[INFO] Building Oracle WebLogic Server Deploy Tooling 0.15                [1/3]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-build-environment) @ 
weblogic-deploy ---
[INFO]
[INFO] ---------< com.oracle.weblogic.lifecycle:weblogic-deploy-core >---------
[INFO] Building weblogic-deploy-core 0.15                                 [2/3]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-build-environment) @ 
weblogic-deploy-core ---
[INFO]
[INFO] ------< com.oracle.weblogic.lifecycle:weblogic-deploy-installer >-------
[INFO] Building weblogic-deploy-installer 0.15                            [3/3]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-build-environment) @ 
weblogic-deploy-installer ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Oracle WebLogic Server Deploy Tooling 0.15:
[INFO]
[INFO] Oracle WebLogic Server Deploy Tooling .............. SUCCESS [  0.477 s]
[INFO] weblogic-deploy-core ............................... SUCCESS [  0.122 s]
[INFO] weblogic-deploy-installer .......................... SUCCESS [  0.019 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.784 s
[INFO] Finished at: 2018-12-21T14:48:21-06:00
[INFO] ------------------------------------------------------------------------

D:\projects>
{quote}


> .mvn directory should be picked when using --file
> -------------------------------------------------
>
>                 Key: MNG-5889
>                 URL: https://issues.apache.org/jira/browse/MNG-5889
>             Project: Maven
>          Issue Type: Improvement
>          Components: Bootstrap &amp; Build
>    Affects Versions: 3.3.3, 3.3.9
>            Reporter: Daniel Spilker
>            Assignee: Tibor Digana
>            Priority: Major
>             Fix For: 3.5.0-alpha-1, 3.5.0
>
>
> The {{.mvn}} directory is not picked up when using the {{--file}} switch to 
> build a project from outside of the multi-module root.
> Example:
> * the module root is {{/foo/bar}}
> * {{.mvn}} is located at {{/foo/bar/.mvn}}
> * current directory is {{/foo}}
> * Maven is invoked with {{mvn --file bar/module/pom.xml}}
> I would expect the {{.mvn}} directory detection to start at the directory of 
> the POM selected by {{--file}} and then go through the parent directories.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (MNG-5889) .mvn directory should be picked when using --file

Reply via email to