bturner commented on a change in pull request #138: SUREFIRE-1309: Clarifying 
use of regular expressions for inclusion/exclusion
URL: https://github.com/apache/maven-surefire/pull/138#discussion_r232918244
 
 

 ##########
 File path: 
maven-surefire-plugin/src/site/apt/examples/inclusion-exclusion.apt.vm
 ##########
 @@ -164,7 +164,16 @@ Inclusions and Exclusions of Tests
 +---+
 
   Note the syntax <<<%regex[expr]>>>, where <<<expr>>> is the actual 
expression and the rest is just wrapping. Also
-  note that regex matches are done over <<<*.class>>> files and not 
<<<*.java>>> files.
+  note the following about the use of regular expressions:
+
+   * Regex matches are done over <<<*.class>>> files and not <<<*.java>>> files
+
+   * Regex matches are done over paths using slashes ("<<</>>>") and not 
package names using dots ("<<<.>>>"), so the
+      "<<<.>>>" in <<<pkg.*Slow.*.class>>> is a regex metacharacter, which 
happens to match any character, notably
+      the (forward) slashes ("<<</>>>") that make up the path. Slashes here 
are <forward>, even on Windows
 
 Review comment:
   How will that approach work for being able to specify packages? When unit 
tests run, we don't want to run anything with an `it` package at its root. 
Having to specify fully qualified classnames for every single integration test 
to not run in the Surefire configuration and then either specify every 
integration test to run in Failsafe or every unit test not to run would be a 
configuration nightmare.
   
   We had been using `it/**` until we upgraded Surefire/Failsafe, but now that 
has a behavior of automatically prepending `**/` to any pattern that doesn't 
start with it, which ignores any class with an `it` package anywhere, rather 
than just at the root. We switched to `%regex` to work around that change.
   
   Does the new solution have some sort of wildcard syntax planned? And, if so, 
will it have a way to say we don't want any "helpful" modifications to what we 
configure?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to